fix api key generation issue#114
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a UserID field to the principal struct to explicitly separate internal system user IDs from external OIDC subjects. This change is propagated through the authentication layers, including OIDC JWT, platform JWT, and API key authentication, ensuring that internal identifiers are consistently used for resource management and database lookups. Corresponding tests were added to verify the preference for the internal UserID and its correct handling in API endpoints. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 57.15% 51.64% -5.52%
==========================================
Files 59 72 +13
Lines 10448 10679 +231
==========================================
- Hits 5972 5515 -457
- Misses 3905 4580 +675
- Partials 571 584 +13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Hi @ankitkatewa rebase on main and follow https://docs.mcpruntime.org/getting-started/#3-contributor-test-mode-cluster to test this out. |
3 participants
No description provided.